At a glance
- Identifier: #472
- Stage: RFC 3 / Accepted
- Champion: @OlegIlyenko
- Latest activity: Spec PR merged on 2020-01-10
- Spec PR: https://github.com/graphql/graphql-spec/pull/472
Spec PR description
This proposal directly relates to a discussion in https://github.com/facebook/graphql/issues/429. As was discussed at the latest WG meeting, I'm creating several alternative proposals. This one implements proposed solution 4. Limit the validation to only these directives that are explicitly marked as "unique". This implies that we need to introduce a new option in the directive definition.
It limits the scope of "Directives Are Unique Per Location" to directives that are explicitly marked as unique.
This proposal is mutually exclusive with other alternative proposals:
- [RFC] Limit uniqueness to
@skip,@includeand@deprecateddirectives (#471) - [RFC] Limit directive uniqueness to explicitly marked directives (#472, this one)
@leebyron @IvanGoncharov @jjergus I would appreciate your reviews.
Closes #429 Closes #471
Timeline
January 2020
- Spec PR merged on 2020-01-10 by leebyron
- 2 commits pushed on 2020-01-10
- @leebyron committed "Apply suggestions from code review"
- @leebyron committed "Editorial"
- Advanced to RFC 3 on 2020-01-10 by leebyron
October 2019
November 2018
- Advanced to RFC 2 on 2018-11-06 by leebyron
October 2018
- @OlegIlyenko committed "Improved `repeatable` directive description" on 2018-10-08
- 2 commits pushed on 2018-10-05
- @OlegIlyenko committed "Improved repeatable directive example"
- @OlegIlyenko committed "Better description for `repeatable` directives"
- @OlegIlyenko committed "Rename `repeatable` → `isRepeatable` in the introspection" on 2018-10-04
- @OlegIlyenko committed "Use `repeatable` instead of `unique` keyword. Also changed the default." on 2018-10-02
- Advanced to RFC 1 on 2018-10-02 by leebyron
June 2018
- Top comment edited on 2018-06-25 by OlegIlyenko
- @OlegIlyenko committed "Mark `@skip`. `@include` and `@deprecated` as unique" on 2018-06-25
- Top comment edited on 2018-06-24 by OlegIlyenko
- Spec PR created on 2018-06-24 by OlegIlyenko
- @OlegIlyenko committed "Limit directive uniqueness to explicitly marked directives" on 2018-06-24